Closed emmahodcroft closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hodcroftlab/covariants/J8PZsDhFbgpLpgQwCaasqPTsktaX
✅ Preview: https://covariants-git-updateseometa-hodcroftlab.vercel.app
Hm... the deployment is working for the 'main' pages (Per Variant, Shared Mutations, etc) but not for the variant or mutation pages. I think I see how I messed up.
Seems to be working now!
If merged, this will solve the issue I described and can be closed.
Maybe automated page titles and descriptions should be a separate issue to be tracked separately.
I am not against merging. It's tedious to update this way, but if not updated the missing page will just show the defaults. So not a big deal.
Yes, having something automatic would be better, as keeping this up to date will be hard to remember. However, I was able to do this in a few minutes so figured it was worth doing in the meantime - but it doesn't preclude creating a better solution, if someone (or @azizLIGHT) has the time!
Ok, I'll merge this in now. But better solutions welcome!
As raised in #288 - not all pages have updating titles or descriptions.
This is a quick manual update so that we have some more specific details for each page. (I scripted the part with the variants/mutations.)
@ivan-aksamentov , are there restrictions on what symbols can be used in these headers/descriptions? I used the
build_name
object fromclusters.py
- so it might have things like spaces and parenthesis. I think this should be fine, but if you could eyeball it quickly, that would be good!Also, I left out the
image
variable for the other pages as we don't have specific images - is that the right way to do that?