search

hodcroftlab / covariants

Real-time updates and information about key SARS-CoV-2 variants, plus the scripts that generate this information.
https://covariants.org/
GNU Affero General Public License v3.0
316 stars 111 forks source link

fix(web): add missing country flags #290

Closed ivan-aksamentov closed 2 years ago

ivan-aksamentov commented 2 years ago

This adds a few country names to the exceptions list, in order for flags to be rendered correctly.

This is due to inconsistent naming we use, which is not compliant with ISO-3166-1 Alpha-2 Code and with the the flag library we are using.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hodcroftlab/covariants/BUx5dhscS82YB8ao7ajr3sVHUf4i
✅ Preview: https://covariants-git-fix-add-missing-countries-hodcroftlab.vercel.app

emmahodcroft commented 2 years ago

Thank you Ivan! Happy for you to merge this in when you think it's ready.

emmahodcroft commented 2 years ago

Urgh, I didn't mean to close that. Sorry. Mouse spasm.

ivan-aksamentov commented 2 years ago

@emmahodcroft Just a quick note:

  'Saint Martin': 'SX',
  'Sint Maarten': 'SX',

are probably the same thing. Check on Python side that there aren't any bugs.

emmahodcroft commented 2 years ago

Hmmm. Good spotting. We take things straight from the metadata file in Nextstrain, and don't change anything within CoV that I can remember. @MoiraZuber would you mind checking the ncov-ingest info to see if these are sometimes not being corrected?