hodcroftlab / covariants

Real-time updates and information about key SARS-CoV-2 variants, plus the scripts that generate this information.
https://covariants.org/
GNU Affero General Public License v3.0
317 stars 111 forks source link

Add 22A, B, C Clades #307

Closed emmahodcroft closed 2 years ago

emmahodcroft commented 2 years ago

Not ready to merge quite yet, but preparing.

Need to do a full run to include graph data for things to work properly...

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
covariants ✅ Ready (Inspect) Visit Preview May 3, 2022 at 4:54PM (UTC)
emmahodcroft commented 2 years ago

Not entirely sure why failing. May be because I "turned on" display yet there is missing data (no run with the new definitions). This will be easier to debug on the full test branch.

emmahodcroft commented 2 years ago

I DID NOT MEAN TO CLOSE

ivan-aksamentov commented 2 years ago

@emmahodcroft Vercel says:

../content/clusters/22B.Omicron.md:22:16
Syntax error: Unterminated JSX contents.
  20 | <p><em parentName="p">{`Please help by providing links to further information about this variant if you can!`}</em></p>
  21 | <p><em parentName="p">{`(Thanks to Erik Boehm for his work on curating information relating to 22A-22C, which was used on these pages)`}</em></p>
> 22 |     </MDXLayout>
     |                 ^
  23 |   )
  24 | };
  25 | MDXContent.isMDXComponent = true

Something's wrong with the markdown content. Perhaps there's an unclosed tag? Or something that makes markdown parser to think there is.

~Also I cannot find a file 22A22B_Spike.md which you import and use as SpikeAB. This might be it or it and something else.~ No, sorry, the file is there.

ivan-aksamentov commented 2 years ago

It was missing an import

import SpikeAB from 'content/clusters/22A22B_Spike.md'

in content/clusters/22B.Omicron.md

And a couple of <br/> tags were not closed.

emmahodcroft commented 2 years ago

Ah yes, I see how that happened... I was so careful to do it for 22A, then when I copied it all for 22B... 🙃

emmahodcroft commented 2 years ago

Thanks Ivan, I've also copied these over to my branch that'll have all the run on it!

emmahodcroft commented 2 years ago

Closing this because the trial PR worked so well, I'll just merge that in.