search

hodgef / simple-keyboard

Javascript Virtual Keyboard - Customizable, responsive and lightweight
https://virtual-keyboard.js.org/
MIT License
2.22k stars 170 forks source link

Removed console.log #2310

Closed aniketkumar5676 closed 3 months ago

aniketkumar5676 commented 3 months ago

Description

A few sentences describing the overall goals of the pull request's commits.

Checks

github-actions[bot] commented 3 months ago

:wave: Hello @aniketkumar5676! Please make sure to review the Contributing Guidelines to ensure your PR is compliant. Thank you!

aniketkumar5676 commented 3 months ago

Removed console.log

ssonawane commented 3 months ago

Dear hodgef,

Requesting you to remove console.log from your code. We are using your library in my application, but logs are printed in the console, security team wants us to remove it.

hodgef commented 3 months ago

@ssonawane,

All the logs in simple-keyboard are behind the option debug, which is set to false by default. Did you turn the option to true by mistake? Also, these logs are not a security concern in any way.

image

https://hodgef.com/simple-keyboard/documentation/options/debug/

Since I thought this PR was spam I effected a ban on the submitter - I would recommend creating an issue instead explaining the why of your change. Per the Contributing Guidelines:

Discuss the change you wish to make with the owners of this repository before raising a PR. If you do not discuss it beforehand, your PR might end up being rejected and your work will be lost.

https://github.com/hodgef/simple-keyboard/blob/master/CONTRIBUTING.md