hodgepodgers / ng-intl-tel-input

AngularJS 1.4.x module implementing intl-tel-input (https://github.com/Bluefieldscom/intl-tel-input)
MIT License
110 stars 111 forks source link

Upgrades to intl-tel-input:14.0.0 and fixes protractor tests #127

Closed pitpit closed 4 months ago

pitpit commented 6 years ago

fixes #126

End-to-end test with protractor and firefox were broken :

I try updating protractor to each major latest version (4.0.14, 3.3.0, 2.5.1) but no one supports firefox 56.0.2. I had to update protractor to latest release: 5.4.1 using gecko webdriver 0.19.0.

Unfortunately protractor@5.4.1 is only supported on node>=4.9.x, so I replaced test coverage from Node from 0.12 to 5.x by Node from 6.x to 10.x in .travis.yml

pitpit commented 6 years ago

protractor tests failed because rate limit of github is reached...

(node:4224) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Failed to make Github request, rate limit reached.

I will give a try tomorrow

pitpit commented 6 years ago

hi @bighappyface, could you add a github access token to travis to avoid rate limit in travis ? I fixed all tests but it continues to fail because that rate limit reached...

pitpit commented 5 years ago

up