hodgerpodger / staketaxcsv

python repo to create blockchain CSVs
MIT License
252 stars 119 forks source link

api_lcd_v1: numeric order_by, total w/o pagination #369

Closed dckc closed 1 week ago

dckc commented 1 week ago

odd... now the online service is working fine for BLD.

I was getting errors, so I tried running it locally. I had to make these 2 fixes to get a BLD report.

hodgerpodger commented 1 week ago

Thanks! I'll mull over this one a day or two to make sure I understand (haven't visited BLD nuances in a long time).

hodgerpodger commented 1 week ago

Ah ok the BLD report is using an archive rpc node, STAKETAX_BLD_NODE_RPC.

Unless I'm not seeing it correctly, I think these code changes (api_lcd*.py) touch code not used by the BLD report, which uses api_rpc_multinode.py.

dckc commented 1 week ago

Thanks for looking into it.

Thanks for the DM offer; perhaps at some point I'll take you up on it.

But for now I'm satisfied with the online service.