Remove Bits add Sats + Fix repeated address bug + share sheets (already on develop)

hodlwallet / hodl-wallet-android

HODL Wallet : Bitcoin Android Wallet

https://hodlwallet.com

MIT License

10 stars 14 forks source link

Remove Bits add Sats + Fix repeated address bug + share sheets (already on develop) #38

Closed igorgue closed 5 years ago

igorgue commented 5 years ago

This contains the following changes:

Removes Bits and MBits
Adds Satoshi (SAT)
Fix send screen switch from Fiat Currency to BTC or Satoshi

What's not included:

Fix sweep private key: Unfortunately, this requires more code, and work will be done in another PR that includes changes for our core library that we forgot to do when renaming the project.

igorgue commented 5 years ago

@arubinofaux & @edgarnet before merging this, we need to make sure I can update the breadwallet-core library with it just like I just did on iOS...

edgarnet commented 5 years ago

Updates to the core library build and run as expected.

edgarnet commented 5 years ago

There's an issue on my end with BRKey.java: No implementation found for boolean co.jniwrappers.BRKey.setPrivKey(byte[]). Similar wrappers may also be prone to error.

igorgue commented 5 years ago

I’ll check it out. I think I fixed those.

On Fri, Feb 15, 2019 at 6:52 PM Edgar Perez notifications@github.com wrote:

There's an issue on my end with BRKey.java: No implementation found for boolean co.jniwrappers.BRKey.setPrivKey(byte[])

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hodlwallet/hodl-wallet-android/pull/38#issuecomment-464252056, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAbZq83K5C5l093OfGca7rMVdbhO3lfks5vN0g5gaJpZM4a1K5n .

igorgue commented 5 years ago

@edgarnet fixed that, thanks!

edgarnet commented 5 years ago

Builds and runs as expected on my end.