hoehermann / purple-gowhatsapp

Pidgin/libpurple plug-in for WhatsApp Web.
GNU General Public License v3.0
287 stars 35 forks source link

error: label at end of compound statement #144

Closed Nardol closed 1 year ago

Nardol commented 1 year ago

It looks like there is a remaining error in revision 93e07296286c197c16d4eb1a7828212a139de374

$ cmake --build .
Scanning dependencies of target purple-dummy
[  4%] Building C object src/go/CMakeFiles/purple-dummy.dir/purple-dummy.c.o
[  8%] Building C object src/go/CMakeFiles/purple-dummy.dir/__/c/constants.c.o
[ 13%] Linking C static library libpurple-dummy.a
[ 13%] Built target purple-dummy
Scanning dependencies of target purple-go-whatsapp
[ 17%] Generating purple-go-whatsapp.a, purple-go-whatsapp.h
go: downloading github.com/alfg/mp4 v0.0.0-20210728035756-55ea58c08aeb
go: downloading github.com/go-sql-driver/mysql v1.6.0
go: downloading github.com/lib/pq v1.10.4
go: downloading github.com/mattn/go-sqlite3 v1.14.10
go: downloading github.com/mdp/qrterminal/v3 v3.0.0
go: downloading github.com/skip2/go-qrcode v0.0.0-20200617195104-da1b6568686e
go: downloading go.mau.fi/whatsmeow v0.0.0-20221228122648-8db2c068c345
go: downloading google.golang.org/protobuf v1.28.1
go: downloading rsc.io/qr v0.2.0
go: downloading go.mau.fi/libsignal v0.0.0-20221015105917-d970e7c3c9cf
go: downloading golang.org/x/crypto v0.0.0-20221012134737-56aed061732a
go: downloading filippo.io/edwards25519 v1.0.0
go: downloading github.com/gorilla/websocket v1.5.0
[ 21%] Built target purple-go-whatsapp
Scanning dependencies of target whatsmeow
[ 26%] Building C object src/c/CMakeFiles/whatsmeow.dir/init.c.o
[ 30%] Building C object src/c/CMakeFiles/whatsmeow.dir/login.c.o
[ 34%] Building C object src/c/CMakeFiles/whatsmeow.dir/qrcode.c.o
[ 39%] Building C object src/c/CMakeFiles/whatsmeow.dir/bridge.c.o
[ 43%] Building C object src/c/CMakeFiles/whatsmeow.dir/process_message.c.o
[ 47%] Building C object src/c/CMakeFiles/whatsmeow.dir/display_message.c.o
[ 52%] Building C object src/c/CMakeFiles/whatsmeow.dir/groups.c.o
[ 56%] Building C object src/c/CMakeFiles/whatsmeow.dir/blist.c.o
[ 60%] Building C object src/c/CMakeFiles/whatsmeow.dir/constants.c.o
[ 65%] Building C object src/c/CMakeFiles/whatsmeow.dir/send_message.c.o
[ 69%] Building C object src/c/CMakeFiles/whatsmeow.dir/handle_attachment.c.o
[ 73%] Building C object src/c/CMakeFiles/whatsmeow.dir/send_file.c.o
[ 78%] Building C object src/c/CMakeFiles/whatsmeow.dir/presence.c.o
[ 82%] Building C object src/c/CMakeFiles/whatsmeow.dir/options.c.o
[ 86%] Building C object src/c/CMakeFiles/whatsmeow.dir/receipt.c.o
[ 91%] Building C object src/c/CMakeFiles/whatsmeow.dir/pixbuf.c.o
[ 95%] Building C object src/c/CMakeFiles/whatsmeow.dir/commands.c.o
/home/pzajda/git/purple-gowhatsapp/src/c/commands.c: In function ‘execute_command’:
/home/pzajda/git/purple-gowhatsapp/src/c/commands.c:31:9: error: label at end of compound statement
         default:
         ^~~~~~~
make[2]: *** [src/c/CMakeFiles/whatsmeow.dir/build.make:271: src/c/CMakeFiles/whatsmeow.dir/commands.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:179: src/c/CMakeFiles/whatsmeow.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
hoehermann commented 1 year ago

It seems the compiler in use does not like empty default cases. I put in an explicit return. Feel free to try again with 4b496d2.

Nardol commented 1 year ago

It works, thanks for the fix! :+1:

hoehermann commented 1 year ago

By the way: Thank you for testing between releases. Your feedback is valuable. :)