hoehermann / purple-gowhatsapp

Pidgin/libpurple plugin for WhatsApp Web.
GNU General Public License v3.0
277 stars 34 forks source link

nil pointer dereference gowhatsapp_go_query_group_participants #145

Closed samtrek closed 1 year ago

samtrek commented 1 year ago

After updating to the latest purple-gowhatsapp, pidgin suddenly freezes and crashes, I ran pidgin from terminal and the following is the output of the crash

` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x1c8 pc=0x7ff93f8c46ee]

goroutine 17 [running, locked to thread]: main.gowhatsapp_go_query_group_participants(0x55596da4f380, 0xc000006601?) `

hoehermann commented 1 year ago

Thank you for the report. It looks like me being lazy finally catches up to me as seen in these TODOs. I want to look into it tonight. Did you build from the default branch whatsmeow or tag v1.8.0?

samtrek commented 1 year ago

Default branch, it seems to be because it is automatically updated by my package manager (Archlinux, AUR).

hoehermann commented 1 year ago

Feel free to try again with a1fdc38. The issue probably won't be resolved, but we should get more debug information.

samtrek commented 1 year ago

I have updated to a1fdc38 and it seems as if it is somehow stable for now, have not observed any crahses so far, so should the issue be closed?

hoehermann commented 1 year ago

Yes. In case the problem arises again, just re-open this issue. :)

Side-note: This can only happen if the plug-in tries to get information on a group without knowing the group ID. This should not be happening in the first place.