search

hoehermann / purple-gowhatsapp

Pidgin/libpurple plug-in for WhatsApp Web.
GNU General Public License v3.0
287 stars 35 forks source link

Parameter name omitted #150

Closed Nardol closed 1 year ago

Nardol commented 1 year ago 
$ cmake --build .
Scanning dependencies of target purple-dummy
[  4%] Building C object src/go/CMakeFiles/purple-dummy.dir/purple-dummy.c.o
[  8%] Building C object src/go/CMakeFiles/purple-dummy.dir/__/c/constants.c.o
[ 13%] Linking C static library libpurple-dummy.a
[ 13%] Built target purple-dummy
Scanning dependencies of target purple-go-whatsapp
[ 17%] Generating purple-go-whatsapp.a, purple-go-whatsapp.h
go: downloading github.com/mattn/go-sqlite3 v1.14.10
go: downloading github.com/alfg/mp4 v0.0.0-20210728035756-55ea58c08aeb
go: downloading github.com/lib/pq v1.10.4
go: downloading github.com/mdp/qrterminal/v3 v3.0.0
go: downloading github.com/skip2/go-qrcode v0.0.0-20200617195104-da1b6568686e
go: downloading go.mau.fi/whatsmeow v0.0.0-20230104001256-9d98dc9b5702
go: downloading github.com/go-sql-driver/mysql v1.6.0
go: downloading google.golang.org/protobuf v1.28.1
go: downloading rsc.io/qr v0.2.0
go: downloading go.mau.fi/libsignal v0.1.0
go: downloading filippo.io/edwards25519 v1.0.0
go: downloading golang.org/x/crypto v0.4.0
go: downloading github.com/gorilla/websocket v1.5.0
[ 21%] Built target purple-go-whatsapp
Scanning dependencies of target whatsmeow
[ 26%] Building C object src/c/CMakeFiles/whatsmeow.dir/init.c.o
/home/pzajda/git/pidgin/gowhatsapp/src/c/init.c: In function ‘plugin_init’:
/home/pzajda/git/pidgin/gowhatsapp/src/c/init.c:131:25: error: parameter name omitted
 static void plugin_init(PurplePlugin *) {
                         ^~~~~~~~~~~~~~
make[2]: *** [src/c/CMakeFiles/whatsmeow.dir/build.make:63: src/c/CMakeFiles/whatsmeow.dir/init.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:179: src/c/CMakeFiles/whatsmeow.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Git revision: 68c6c28fa29a46d55cc632c12732fc70db9df6a3 Also tried after cleaning build directory and after a git reset --hard with the same result.

hoehermann commented 1 year ago

Indeed, I omitted the parameter name. And purposefully so – since I am not using the parameter in that function. Which compiler are you using? With default settings, GCC 11 builds successfully without warnings.

Update: I can confirm: It does not work with GCC 9.

hoehermann commented 1 year ago

Got it ff71b58. Should build again with older versions of GCC and glib. If I am mistaken, feel free to re-open this issue.