hoehermann / purple-gowhatsapp

Pidgin/libpurple plug-in for WhatsApp Web.
GNU General Public License v3.0
289 stars 34 forks source link

packaging support using cpack #169

Closed beadon closed 1 year ago

beadon commented 1 year ago
hoehermann commented 1 year ago

Thank you. I want to look into this within a fortnight.

beadon commented 1 year ago

note the versioning addition here to the cmake config. This makes packaging and dependency checking easier.

hoehermann commented 1 year ago

I think I understood most of the changes. I rebased onto the main branch and squashed commits to my liking. Thank you for the contribution.

beadon commented 1 year ago

I think I understood most of the changes. I rebased onto the main branch and squashed commits to my liking. Thank you for the contribution.

I appreciate the acceptance!

I raised some points to agree for - versioning, and dependencies. Can you take a quick look at these to see if the proposal make sense ? I don't want to break you/repo workflow with a bad suggestion/implementation.