search

hoehermann / purple-gowhatsapp

Pidgin/libpurple plug-in for WhatsApp Web.
GNU General Public License v3.0
287 stars 35 forks source link

Trying to join a group with JID="status@broadcast" makes pidgin hang #195

Closed Juliaria08 closed 4 months ago

Juliaria08 commented 5 months ago

The title is self explanatory. I wanted to try to join the special group, but I couldn't from the join a chat menu. I typed in:

JID: status@broadcast
Name: status

And pidgin hangs, (and to kill it I have to send it another signal different from SIGTERM for it to stop)

Thanks in advance.

hoehermann commented 5 months ago

Thank you for your message. I think status@broadcast technically is a contact, not a group. The plug-in is calling Client.GetGroupInfo, which does take a long time to timeout when fed with invalid data.

Apart from that, I have to tell you I never could get status broadcasts to work. Or any other of the special servers known to jid.go:

LegacyUserServer  = "c.us"
BroadcastServer   = "broadcast"
HiddenUserServer  = "lid"
MessengerServer   = "msgr"
InteropServer     = "interop"
NewsletterServer  = "newsletter"
HostedServer      = "hosted"

In case of the broadcast server: For some users it works, for some it does not. It was working for me for some time, then it stopped working and receiving messages from it produced crashes. Since my actual contacts do not use broadcasts at all and I fail to generate broadcasts in my test environment, I have a hard time developing support for these servers. I am sorry, but I cannot add features involving the broadcast server. Contributions are welcome. 🙂

That said, I consider only the default (single contact conversation) and group chat server to be supported:

DefaultUserServer = "s.whatsapp.net"
GroupServer       = "g.us"
Juliaria08 commented 5 months ago

Ah, ok.

Juliaria08 commented 5 months ago

(they are working for me when one of my contacts sends a broadcast)

hoehermann commented 5 months ago

I just noticed that https://pkg.go.dev/go.mau.fi/whatsmeow#section-readme states:

Things that are not yet implemented: Sending broadcast list messages (this is not supported on WhatsApp web either)

Since receiving works, I consider the temporary UI lock-up upon trying to join a non-existent group a minor issue.

Juliaria08 commented 4 months ago

Ok, then I'll close.