Pairing phone with a 8-letter code

hoehermann / purple-gowhatsapp

Pidgin/libpurple plug-in for WhatsApp Web.

GNU General Public License v3.0

287 stars 35 forks source link

Pairing phone with a 8-letter code #204

Closed ReinJG closed 2 months ago

ReinJG commented 4 months ago

Could the functionality of pairing a phone with a 8-letter code instead of a QR code be added?

This is implemented in for example mautrix/whatsapp by using the method Client.PairPhone from the whatsmeow library.

hoehermann commented 4 months ago

Thank you for the suggestion. It is very reasonable. I did not even know of this feature. No estimate when I want to do it, though.

hoehermann commented 2 months ago

Implemented in 21b78e6. I added extra detailed descriptions when used with terminal-based clients. I hope it helps. Feed-back is welcome. Since this will affect protocol bridges more than Pidgin users, I hope that some folks can run tests in their set-ups. @mverboom @mooomooo @demure @Strykar @yourealwaysbe @quotuva @evgenyh @heeplr or @msebald maybe?

yourealwaysbe commented 2 months ago

Awesome! -- i run WhatsApp on an old phone whose camera struggles with QR codes. The 8 letter code is much more convenient and doesn't require WeeChat plugins to render.

The first code didn't work for me and i had to reconnect to get a new one. I assume the codes timeout like the QR codes and i was too slow. Maybe it's worth adding a remark to the "Please enter..." message to avoid surprised users?