hoehermann / purple-signald

Pidgin libpurple bridge to signald.
GNU General Public License v3.0
153 stars 19 forks source link

Cannot message particular user due to "identityFailure" #53

Open BenWiederhake opened 3 years ago

BenWiederhake commented 3 years ago

pidgin -d prints:

(09:38:42) prpl-hehoe-signald: signald_send_im: flags: 1 msg:Well, now I finally know why you didn't respond: My signal client somehow lost the message xD
(09:38:42) prpl-hehoe-signald: Sending: {"type":"send","username":"+49AAAAAAAAAAA","recipientAddress":"+49BBBBBBBBBB","attachments":[],"messageBody":"Well, now I finally know why you didn't 
respond: My signal client somehow lost the message xD"}
(09:38:42) prpl-hehoe-signald: got newline delimited message: {"type":"send_results","data":[{"address":{"number":"+49BBBBBBBBBB","uuid":"1e4d55e7-7040-414a-9f6c-5e4aac138f43"},"networkFailu
re":false,"unregisteredFailure":false,"identityFailure":"05 ed c6 4c 29 31 b2 aa 2a 5b 54 53 5c b4 6a aa 96 8b 7f d0 32 81 a4 31 15 98 c1 b6 9f b0 b1 12 39"}]}
(09:38:42) prpl-hehoe-signald: received type: send_results
(09:38:42) prpl-hehoe-signald: Ignored message of unknown type 'send_results'.

The returned string in identityFailure is always the same; presumably it's some kind of "new public key".

I couldn't find anything about this error in the entire repository. How do I fix this "broken" state?

hoehermann commented 3 years ago

Does not happen on my system (with signald 0.13.1). I do not know how to reproduce this issue. :(

Bildschirmfoto_2021-06-29_17-47-36

I only have old, known contacts and groups to test with, though. Does this happen with everyone or just some contacts? Could it be an issue with a new official client version, re-generated keys on new or known contacts?

BenWiederhake commented 3 years ago

Does this happen with everyone or just some contacts?

Only one particular contact, as far as I can see.

Could it be an issue with a new official client version, re-generated keys on new or known contacts?

My best guess is re-generated keys. In the mobile client, it says "Deine Sicherheitsnummer mit hat sich geändert." (Apparently you speak German, so I think sticking to the original text is a good idea.)

It does not seem to be related to whether I have a contact with them or not. I don't have information about client versions.

hoehermann commented 3 years ago

My best guess is re-generated keys.

Maybe I can force key re-generation on one of my test clients and reproduce this error.

And, yes, German is my main language. :)

hoehermann commented 2 years ago

Today, I had the opportunity to test this since I accidentally wiped one of my test devices. Commit 89dd6ff now detects the problem. To overcome it, I would need to implement sending a trust request. Much to do for something I expect to happen infrequently. I want to keep this issue open so I do not forget about it.