search

hoellen / dockerfiles

Dockerfiles
https://hub.docker.com/u/hoellen
Creative Commons Zero v1.0 Universal
36 stars 17 forks source link

Adding enviroment variable SESSION_GC_MAXLIFETIME #52

Closed waja closed 3 years ago

waja commented 3 years ago

When setting 'autologout' => true, this will happen after session_lifetime. The maximum possible time is limited by the session.gc_maxlifetime, so it makes sense to be able to adjust this value. (see https://github.com/nextcloud/server/pull/26007/commits/296332efa38d25e18ffe066843d707bbc835068c)

waja commented 3 years ago

Is there anything that should be changed to get this merged?

hoellen commented 3 years ago

Why should this be configurable as Docker environment variable? You can easily set this PHP config by mounting a file as volume to the path /php/conf.d/session.ini with the following content:

session.gc_maxlifetime=1440

I don't necessarily want to increase the number of configuration settings.

waja commented 3 years ago

Why should this be configurable as Docker environment variable?

For the same reason this is be done with the other environment variables adjusting the PHP behavior. For convenient.

hoellen commented 3 years ago

I'm going to get rid of the other environment variables, too.

waja commented 3 years ago

I'm going to get rid of the other environment variables, too.

hehe ... okay, go for it! :)