search

hoelzer / dfg

A LaTeX template for a basic DFG (Deutsche Forschungsgemeinschaft, German Research Foundation) grant proposal.
GNU General Public License v3.0
73 stars 45 forks source link

Various minor changes #13

Closed hkarl closed 3 years ago

dl1chb commented 3 years ago

You added a bibressource called "Karl-Holger.bib" which is not present in your repo. So it does not build. Besides the fact this file is missing, it's name implies no general use but a personal use for you. For a template such things are no good idea in general.

I just wanted to check what you modified, but from all the 8 commits addressing different purposes it is hard for me to get it. I am not the maintainer of this repo, but I think you should explain what you did and why you want this to be merged.

hkarl commented 3 years ago

You added a bibressource called "Karl-Holger.bib" which is not present in your repo. So it does not build. Besides the fact this file is missing, it's name implies no general use but a personal use for you. For a template such things are no good idea in general.

I just wanted to check what you modified, but from all the 8 commits addressing different purposes it is hard for me to get it. I am not the maintainer of this repo, but I think you should explain what you did and why you want this to be merged.

All good points. It actually was a suggestion of the repo's maintainer that I do a pull request so he can have a look. I agree that most commits don't matter, maybe commit 670b7c7 is useful; tcolorbox seems more useful than the direct Tick-based approached taken in the original. But I am perfectly fine if you just ignore that PR...

dl1chb commented 3 years ago

I can only speak for me. I appreciate your helf and improvement to this as I also took advantage of Martin's work. If you don't mind, i will also have a look at your suggestion as soon as I have time for it. Sorry if it sounded rude, but without any comment before... I think you know what I mean. Thanks for you suggestion!

I also know it is hard to contribute here, because when you do you usually have to write and finish your proposal in time, too. And after that one has other things to do. So I think I can speak for everybody here it is a work which will not give a straight profit on oneself...

hoelzer commented 3 years ago

@hkarl @dl1chb yep I can only agree! First, thanks for the help to keep this template up-to-date while also improving on the current content.

@hkarl I suggest that I will go through your changes to see which are of general interest for the template and include them in another pull request. I think that's the easiest way and by that, some of your changes/ efforts can be still included.

hoelzer commented 3 years ago

@hkarl I like the general idea of moving the main chapters from the overview TeX file to sub-files. However, I would not include this right now because we have now an English and German version so we would also need sub-files for both. Unsure if this brings more confusion than having the two files dfg.tex and dfg-german.tex with the main content. And: we already have the working packages as \input{}s to keep the main TeX files a bit smaller.

Nevertheless, thanks for sharing your changes and maybe we can even make use of them in a future release!