search

hoene / libmysofa

Reader for AES SOFA files to get better HRTFs
Other
137 stars 73 forks source link

Symmetrical center mismatch #150

Closed hoene closed 3 years ago

hoene commented 3 years ago

Thanks to @ygrabit and Steinberg's student for finding this issue. If some symmetrical HRTFs, the center is slighly shifted to the side. Excellent work!

codecov[bot] commented 3 years ago

Codecov Report

Merging #150 (17030a9) into master (129904d) will increase coverage by 0.08%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   85.10%   85.18%   +0.08%     
==========================================
  Files          36       36              
  Lines        3310     3315       +5     
==========================================
+ Hits         2817     2824       +7     
+ Misses        493      491       -2
Impacted Files Coverage Δ
src/hrtf/easy.c 55.67% <0.00%> (ø)
src/hrtf/tools.c 95.04% <ø> (+3.96%) :arrow_up:
src/hrtf/interpolate.c 77.92% <73.33%> (+0.14%) :arrow_up:
src/hrtf/check.c 90.32% <100.00%> (ø)
src/hrtf/loudness.c 96.15% <100.00%> (ø)
src/hrtf/reader.c 82.68% <100.00%> (ø)
src/tests/external.c 81.48% <100.00%> (ø)
src/hrtf/lookup.c 91.52% <0.00%> (-1.70%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20b8d1d...17030a9. Read the comment docs.

hoene commented 3 years ago

@ygrabit By chance, do you have a test case for me so that I can verify the fix?