search

hoene / libmysofa

Reader for AES SOFA files to get better HRTFs
Other
131 stars 70 forks source link

Cache hit does not set the return code #196

Closed dsseng closed 1 year ago

dsseng commented 1 year ago

See https://github.com/hoene/libmysofa/blob/main/src/hrtf/easy.c#L140 . If cache is available, err is not set.

Memory might be uninitialized thus causing random errors. This could be fixed by users if they initialize the var by default

hoene commented 1 year ago

please check the following bug fix: https://github.com/hoene/libmysofa/commit/5d15d92ed1de2e1666fb7d8b10721e2c64a782b1

dsseng commented 1 year ago

Not ready to recompile PipeWire with this revision now. However, doesn't appear to fix what I expected to get fixed. Let me just submit a fix PR.