search

hofff / contao-social-tags

GNU Lesser General Public License v3.0
2 stars 5 forks source link

Type is too strict for Hook? #16

Closed rabauss closed 3 years ago

rabauss commented 3 years ago

We're getting sometimes a type error: Argument 2 passed to Hofff\Contao\SocialTags\EventListener\Hook\NewsReaderListener::onGetContentElement() must be of the type string, null given

Is the Type here too strict? https://github.com/hofff/contao-social-tags/blob/1757470a9950d298de31a47db7851244c133432f/src/EventListener/Hook/NewsReaderListener.php#L43

Unfortunately, I could not reproduce the state in our local develop system, so that I could debug it 👎

rabauss commented 3 years ago

Another extension caused this error because of missing return value!