hofff / contao-social-tags

GNU Lesser General Public License v3.0
2 stars 6 forks source link

Fix title and description fallbacks for news and events #5

Closed fritzmg closed 4 years ago

fritzmg commented 4 years ago

This PR fixes the following things for the News and Event Extractor:

I can undo the sorting of the use statements again if necessary (it's just my IDE that did it automatically).

dmolineus commented 4 years ago

I can undo the sorting of the use statements again if necessary (it's just my IDE that did it automatically).

Yes, pleas follow the coding standards which are checked by PHP Code Sniffer only so far. Just run vendor/bin/phpcs after a composer install. You might use vendor/bin/phpcbf to use the auto fix feature of phpcs.

fritzmg commented 4 years ago

Ah thank you, I was unfamiliar with how to use phpcs to auto-fix, will do 👍

dmolineus commented 4 years ago

Ah thank you, I was unfamiliar with how to use phpcs to auto-fix, will do +1

Yeah the naming is counter intuitive. Will use phpcq v2 when I'll find some time for it. :-)

fritzmg commented 4 years ago

PR is now updated with using TypeUtil::isStringWithContent both for the title and description for news and events.

dmolineus commented 4 years ago

Thanks @fritzmg