Closed fritzmg closed 4 years ago
I can undo the sorting of the use statements again if necessary (it's just my IDE that did it automatically).
Yes, pleas follow the coding standards which are checked by PHP Code Sniffer only so far. Just run vendor/bin/phpcs
after a composer install. You might use vendor/bin/phpcbf
to use the auto fix feature of phpcs.
Ah thank you, I was unfamiliar with how to use phpcs to auto-fix, will do 👍
Ah thank you, I was unfamiliar with how to use phpcs to auto-fix, will do +1
Yeah the naming is counter intuitive. Will use phpcq
v2 when I'll find some time for it. :-)
PR is now updated with using TypeUtil::isStringWithContent
both for the title and description for news and events.
Thanks @fritzmg
This PR fixes the following things for the News and Event Extractor:
description
as the fallback. However, that field is only available in Contao 4.9+, but not in Contao 4.4. This PR uses thedescription
field as the first fallback if present and otherwise generates the description from theteaser
the same way as Contao does.title
/headline
as the fallback. However, in Contao 4.9+ we also have thepageTitle
field for news and events, which will be used for the meta information instead. This PR uses thepageTitle
field as the first fallback if present and otherwise falls back to thetitle
/headline
.I can undo the sorting of the use statements again if necessary (it's just my IDE that did it automatically).