search

hoffmangroup / genomedata

The Genomedata format for storing large-scale functional genomics data.
https://genomedata.hoffmanlab.org/
GNU General Public License v2.0
2 stars 1 forks source link

Add mypy to Genomedata CI #60

Closed EricR86 closed 3 years ago

EricR86 commented 3 years ago

This PR adds mypy type checking for future versions of Genomedata.

It detected an invalid relative import in a non-package (the test directory). The code in question was performing argument parsing in a script never meant to be called directly. Even if it were successful at parsing the args, it would call a function that only used pass.

michaelmhoffman commented 3 years ago

For the avoidance of doubt, I consider approval of something like this that only modifies CI and test code delegated to you.