search

hoffmangroup / segway

Application for semi-automated genomic annotation.
http://segway.hoffmanlab.org/
GNU General Public License v2.0
13 stars 7 forks source link

Implement String labels #168

Closed isaiahah closed 1 year ago

isaiahah commented 1 year ago

As of this request's creation, the branch only implements string labels for the Viterbi method. These changes break the posterior method, so do not merge. This pull request is only for Eric to visualize the changes implemented.

michaelmhoffman commented 1 year ago

I thought we decided that determining colors based on a hash wasn't going to work well, and we were going to do it as part of a reduce step instead of in parallel?

isaiahah commented 1 year ago

We did agree to assign colors during the reduce step, apologies for the confusion of leaving in the hash code change. The change to assign colors in the reduce was implemented as part of the branch changing the output file (https://github.com/hoffmangroup/segway/pull/169), as that required significant changes to the reduction code.

I am planning to keep only that code when both branches are merged into main; however, if you would like me to make the color change in this branch as well for clarity, I can do that. Let me know what you decide.

EricR86 commented 1 year ago

After minor miscommunication and misunderstanding, the changes have been reverted after the merge into master.