search

hoffmangroup / segway

Application for semi-automated genomic annotation.
http://segway.hoffmanlab.org/
GNU General Public License v2.0
13 stars 7 forks source link

Change Segway output to proper BED9 and trackfile with additional lint fixes #169

Closed isaiahah closed 1 year ago

EricR86 commented 1 year ago

@isaiahah can you resolve the conflicts and address the comment in this branch so I can merge safely? Thanks!

EricR86 commented 1 year ago

I think there was a small miscommunication and misunderstanding in this PR. I believe the original thought was to have the PR code changes pass flake8 checks and to likely fix any remaining issues in the codebase in a separate commit/PR.

Since this is all done work now, it's not a big deal. It's just worth noting the extra changes in this PR. I will merge in the flake8 configuration and CI settings into master and those should be merged in here.

EricR86 commented 1 year ago

Please merge master in for updated lint checking.

michaelmhoffman commented 1 year ago

@EricR86 when you merge this, can you please set the name of the commit to include formatting changes so that we won't be confused in future blame. I don't want to separate these out at this point.