search

hogent-cads / AI_MDM_Prototype

GNU Affero General Public License v3.0
0 stars 1 forks source link

Deduplicatie: enkel nog Zingg #51

Closed slievens closed 1 year ago

slievens commented 1 year ago

We gebruiken de dedupe bibliotheek op dit moment niet.

Best de code hiervoor dan verwijderen?

slievens commented 1 year ago

Dedupe code verwijderd in https://github.com/hogent-cads/AI_MDM_Prototype/commit/c15b28ba0df1a0666d5e6d2094ec6fc1c73bd0fa

slievens commented 1 year ago

Pylint maakt duidelijk dat er nog code is achtergebleven in LocalHandler die te maken heeft dedupe. Te verwijderen. src\frontend\Handler\LocalHandler.py:40:8: E1101: Instance of 'DomainController' has no 'create_deduper_object' member (no-member) src\frontend\Handler\LocalHandler.py:43:15: E1101: Instance of 'DomainController' has no 'dedupe_next_pair' member (no-member) src\frontend\Handler\LocalHandler.py:46:15: E1101: Instance of 'DomainController' has no 'dedupe_mark_pair' member (no-member) src\frontend\Handler\LocalHandler.py:49:15: E1101: Instance of 'DomainController' has no 'dedupe_get_stats' member (no-member) src\frontend\Handler\LocalHandler.py:52:15: E1101: Instance of 'DomainController' has no 'dedupe_train' member (no-member) src\frontend\Handler\LocalHandler.py:55:15: E1101: Instance of 'DomainController' has no 'dedupe_get_clusters' member (no-member) src\frontend\Handler\LocalHandler.py:59:15: E1101: Instance of 'DomainController' has no 'create_deduper_object' member (no-member)

slievens commented 1 year ago

Hopelijk nu definitief weg in https://github.com/hogent-cads/AI_MDM_Prototype/commit/2f844d0e8b851cf073b7bf4872ab5fb5904c964f