search

hoggyhoggy / givenergy-modbus-async

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.
Other
1 stars 2 forks source link

redundant code ? #15

Open divenal opened 2 months ago

divenal commented 2 months ago

https://github.com/hoggyhoggy/givenergy-modbus-async/blob/85675ba2a0c03a4a6dd0f7f81d1d3cd65db2716b/givenergy_modbus/model/register_cache.py#L52

Still trying to understand the details of the code... I think these various to_* helpers may be obsolete - replaced by the conversion functions in register.py Converter

I've tried deleting them locally, and don't appear to have broken anything.

hoggyhoggy commented 2 months ago

I need to look through those, I think some work with Timeslots don't they (although maybe that was the old library) I've not actually tried to set timeslots yet - so perhaps it may yet show it's self but lets see!