search

hoggyhoggy / givenergy-modbus-async

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.
Other
1 stars 2 forks source link

Want 1s minimum between requests ? #17

Open divenal opened 2 months ago

divenal commented 2 months ago

https://github.com/hoggyhoggy/givenergy-modbus-async/blob/85675ba2a0c03a4a6dd0f7f81d1d3cd65db2716b/givenergy_modbus/client/client.py#L231

Did we decide that we ought to wait 1s between requests? (This delay is just between sends - not from receipt of response.)

hoggyhoggy commented 2 months ago

It was suggested that a min between requests was 1sec. Although it currently doesn't seem to mind from what I've tried when trying to see how quick it can get.

divenal commented 2 months ago

Yes, it does seem to work fine with faster updates. So it's really just a matter of what it should default to, with a comment that it seems to fine with faster updates if you want to do that.

britkat1980 commented 1 month ago

I’d suggest that 0.5s is fine. 1s would mean an added 7-8s for some models, which have lots more registers to retrieve.