What does read_registers.py is_suspicious do ?

hoggyhoggy / givenergy-modbus-async

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.

Other

1 stars 2 forks source link

What does read_registers.py is_suspicious do ? #35

Open divenal opened 1 month ago

divenal commented 1 month ago

https://github.com/hoggyhoggy/givenergy-modbus-async/blob/315535a154b04a9c18aa232cd4880aa0220b8bc2/givenergy_modbus/pdu/read_registers.py#L141

this defines a function is_suspicious which looks for particular values in particular slots of any block of registers. Doesn't seem to be called from anywhere. Do we know what it's looking for ?

hoggyhoggy commented 1 month ago

There is/was a known bunch of corrupted responses that the inverter could respond with. I did t think this was used anymore however I think Britkat has added a new one so I guess one of the new devices still has known issues?