search

hoggyhoggy / givenergy-modbus-async

A python library to access GivEnergy inverters via Modbus TCP on a local network, with no dependency on the GivEnergy Cloud.
Other
1 stars 2 forks source link

terminology #6

Open divenal opened 2 months ago

divenal commented 2 months ago

https://github.com/hoggyhoggy/givenergy-modbus-async/blob/85675ba2a0c03a4a6dd0f7f81d1d3cd65db2716b/givenergy_modbus/model/plant.py#L54

There seem to be moves in the industry to avoid emotive terms like master and slave. To me, context matters, and in a network environment, no reason for these words to be emotive. That said, from modbus.org, Modbus Organization Replaces Master-Slave with Client-Server (pdf)

All instances of "master-slave" in the organization's literature and on its website will be removed. ... We urge our member companies and all those who use the Modbus protocol to take similar action to rid their documentation and communications of these terms. ... The organization is using "client-server" to describe Modbus communications, characterized by communication between client device (s), which initiates communication and makes requests of server device(s), which process requests and return an appropriate response (or error message).

Though from wikipedia

The organization's naming convention inverts the common usage of having multiple clients and only one server. To avoid this confusion, the RS-485 transport layer uses the terms "node" or "device" instead of "server", and the "client" is not a "node".

I probably prefer node or device rather than server for the sensor.

divenal commented 1 month ago

Any thoughts on this. I'll probably be revisiting this area soon, and if we're going to change this, may as well do it at once.