Fix: uses tr instead of bash4-ism to lower-case

hoglet67 / MMFS

Modern SD Card File System for Acorn 8-bit Machine (Master, Beeb, Electron)

68 stars 17 forks source link

Fix: uses tr instead of bash4-ism to lower-case #24

Closed mincebert closed 3 years ago

mincebert commented 3 years ago

used in name of .ssd file

${var,,} syntax is not available in bash3 (which is standard on macOS, at least up to Catalina)

This prevents building in macOS out of the box, so seems worth fixing. The change works fine on Linux, too, as least on Ubuntu 16.04-20.04 which run bash 4-5 and have 'tr', to.

hoglet67 commented 3 years ago

Thanks, I'll merge this today.

hoglet67 commented 3 years ago

It's merged now.

There was also a use of $(var^^) which I gues might also be a problem.

Sorry I didn't twig when you mentioned this yesterday that there was an issue. I had no idea this was a bash4 only feature.