hoglet67 / MMFS

Modern SD Card File System for Acorn 8-bit Machine (Master, Beeb, Electron)
68 stars 17 forks source link

AFSP matching with leading wildcard is broken #41

Open hoglet67 opened 3 months ago

hoglet67 commented 3 months ago
INFO *MES

Should match GAMES but not BALL. That certainly was the case previously.

Now it's behaving just like:

INFO *

Looks like this is a deliberate simplification: 93494339

This change removes the recursion from the matching.

Dave

hoglet67 commented 3 months ago

Dominic, the original Acorn wildcard matching code was very flexible and would allow matches like:

>*.
MENU (0)
Drive 0             Option 3 (EXEC)
Dir. :0.$           Lib. :0.$

    !BOOT               ACIAIRQ    
    ASPTEST             BLIT       
    BOING               CDUMP1     
    CHCODE   L          CHE00    L 
    CPOF                CPOFBAS    
    CPONBAS             CURSOR     
    DUMP                FBTEST1    
    FBTEST2             FBTEST3    
    FBTEST4             HIPOKE     
    INTTST1             INTTST2    
    INTTST4             IRQDEL     
    ISRTST              KEYTEST    
    MEMPTR1             MENU     L 
    PEKPOK1             R3         
    R3DUMP     

>*INFO *T*ST*
$.ISRTST      FF0E00 FF802B 000088 0B0
$.FBTEST4     FF0E00 FF802B 000106 0AD
$.FBTEST3     FF0E00 FF802B 000187 0AB
$.FBTEST2     FF0E00 FF802B 000184 0A9
$.FBTEST1     FF0E00 FF802B 0000C5 05E
$.INTTST4     FF1900 FF8023 000336 01B
$.INTTST2     FF1900 FF8023 000207 014
$.INTTST1     FF1900 FF8023 0001A7 012
$.KEYTEST     FF2100 FF8023 0000F4 00F
$.ASPTEST     FF2100 FF8023 00022D 00C

My feeling is that moving to the simpler matching will be quickly noticed (I did!)

It's a shame, as reverting adds 31 bytes.