search

hogoww / Illicium

Translation from Pharo to C
3 stars 1 forks source link

Are validator tests really interesting? #23

Closed guillep closed 5 years ago

guillep commented 5 years ago

They do not seem to add much value...

ASTCValidatorTest is super strange... It's not simple to test all possible combinations of isStructuralyValidAST... Also, it looks a lot like defensive programming... I'd like to know if these structural validations helped you in the last months to go faster. Have they?

Even worse: the tests in ASTCValidatorDebugTest are commented and/or not work...

hogoww commented 5 years ago

Nope, the tests are old ones I tried to write while i was writing the validators by hand. Now they are generated, and I have to do tests rights.

The structural validation themselves helped me find flaws in my translation I missed: -Blocks (and stuffs) only contains statement, not expressions. At first, Expression statements wheren't use. -DefinitionVariable isn't a statement either, and yet it should exists into blocks (and stuffs), but currently can't. (<- This one is unresolved)

Besides metamodel inconsistencies issues, writing the translations of methods is error prone, since you write long constructors. It allows me to catch some of theses errors early.

hogoww commented 5 years ago

Still have to write the tests for this (although quite low on my priority list), but I can assess again that those have proven useful.