[improvement] version 3 of ppif print, seems okay

hogoww / Illicium

Translation from Pharo to C

3 stars 1 forks source link

[improvement] version 3 of ppif print, seems okay #65

Closed hogoww closed 4 years ago

guillep commented 4 years ago

Hi Pierre, If you work with PRs, why don't you add comments to them?

hogoww commented 4 years ago

I do, but not currently. Theses are repair from images crashes that failed

guillep commented 4 years ago

My point is:

the PR is not a source of documentation
it has no CI associated to run the tests

So why not just doing a push directly? I mean, it looks like bureaucracy just for the sake of it. Or, if there is another reason, it'd be nice to know it :)

hogoww commented 4 years ago

I was in detached copy, couldn't push directly on main, and was too lazy to copy paste the few things that were lost in the crash If there was an option to checkout the latest commit, and apply the remaining changes in a new one, i'd gladly use it. But if it exists, i'm not aware of it.

But I agree, this is just polluting the history. CI will come soon, since there's starting to be tests interesting enough.