search

hogoww / Illicium

Translation from Pharo to C
3 stars 1 forks source link

evaluateConstant should not evaluate macro #70

Open hogoww opened 4 years ago

hogoww commented 4 years ago

(program hasMethodNamed: aRBMessageNode selector) and:[ ((program methodNamed: aRBMessageNode selector) hasPragmaNamed: #cmacro) not]) ifTrue: [ ^ (program methodNamed: aRBMessageNode selector) body acceptVisitor: self ]. should fix it, but some tests are failing on a formating issue after that, for some reason.

I looked at it thinking it the CMacro was inlined

hogoww commented 4 years ago

failing test with fix Screenshot 2020-02-12 at 11 49 34

bug found on: Screenshot 2020-02-12 at 11 55 09

guillep commented 4 years ago

cmacro is never inlined

Le mer. 12 févr. 2020 à 11:55, hogoww notifications@github.com a écrit :

failing test with fix [image: Screenshot 2020-02-12 at 11 49 34] https://user-images.githubusercontent.com/21278554/74328220-d3f50880-4d8d-11ea-951f-f88714a3d22a.png

bug found on: [image: Screenshot 2020-02-12 at 11 55 09] https://user-images.githubusercontent.com/21278554/74328630-8fb63800-4d8e-11ea-8b5d-12634af35fa6.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hogoww/Illicium/issues/70?email_source=notifications&email_token=AAFM5YXBQABD22CSEGTULZTRCPISLA5CNFSM4KTXJIA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELQKYGY#issuecomment-585149467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFM5YQCA2YTCNYIXWRYFM3RCPISLANCNFSM4KTXJIAQ .

hogoww commented 4 years ago

No, but it is evaluated with the bitshift. Bad description, sorry

On 12/02/2020 12:51, Guille Polito wrote: cmacro is never inlined

guillep commented 4 years ago

Nope, the evaluation does not evaluate macros either. It's the inlining that should not inline macros.