hogsy / jaded

A repository for raising any tickets relating to Jaded, the Community Patched Jade Engine. There is no code here.
https://oldtimes-software.com/jaded/
1 stars 0 forks source link

[BUG] Mad Exports Broken #54

Open MaeDaGoof opened 3 months ago

MaeDaGoof commented 3 months ago

Summary

Exported .mad files crash 3ds max when trying to import them.

Steps to Reproduce

Use any of the export options from the editor, both 'Old Export World to Mad' and the regular one, regardless of selection or texture inclusion. And try importing it into 3ds Max through Ubisoft's plugin. The exporting process works regardless and gives no errors within the editor itself.

Expected Result

The .mad model should properly open in 3ds max without any issues

Actual Result

3DS max gives a general crash error and closes, and textures in general cannot be detected when trying to import them with the model either.

Screenshots or Videos

None that are specific to this issue

Additional Information

This semi worked properly in older verions of Jaded with the Old Export World to Mad option, albeit the textures still weren't being detected when trying to import to 3ds max.

hogsy commented 3 months ago

Note for self; regression was possibly introduced by the following changes.

https://github.com/hogsy/jaded-mirror/commit/cb6d855d0c957a7f7ba1ff805db862c0753c5535#diff-9cd3b0d32f6fdb8af2c29bb8a19c20e9c7667e46197d954184c00995e49c4f4e (this code path shouldn't even be hit with the old export, but this could be what it's unhappy about)

https://github.com/hogsy/jaded-mirror/commit/8b0478ff40866a2cf9e2c4749df88b5e69e7fc3b (not likely)

https://github.com/hogsy/jaded-mirror/commit/f52aeae11de5c65d3b00191912463220592675aa (not likely either, it's just fixing a memory leak on TGA export)

hogsy commented 3 months ago

Note for self; Mae found some extra details as to how this happened. Could probably be resolved by adding some simple validation - I might just pump a warning to the console in such a case.

i selected objects which did not contain geometry and exporting a non geometric object, breaks the export

maybe in that case, best thing to do is give a warning that an object selected has no GRO (the mesh object) attached to it, so it cannot be exported

MaeDaGoof commented 3 months ago

Ok, a small update, it seems that objects with special material and uv settings (like special uv setups in jade and texture blending) crash 3ds max like i mentioned when importing, though it works when using OLD Export World to Mad, but the uv mapping defaults back to the manual setup if the object used jade's own auto mapping settings, and of course lacks the texture blending.