hohMiyazawa / Automail

An enhancement collection for anilist.co
GNU General Public License v3.0
158 stars 30 forks source link

On mobile, action buttons don't stick to the right side of their box. #262

Open krenwi opened 1 year ago

krenwi commented 1 year ago

screenshot

On mobile only, home page and profile page activities action buttons (comments and likes) don't stick to the right side of their box.

krenwi commented 1 year ago

Proposed solution:


.actions .action[data-v-04d66030] {
  padding-left: 15px;
}
.home .activity-entry.activity-text > .wrap > .actions, .user .activity-entry.activity-text > .wrap > .actions {
  width: initial;
}
.home .activity-entry > .wrap > .actions, .user .activity-entry > .wrap > .actions {
  width: inherit;
}
.home .activity-entry > .wrap > .actions .action, .user .activity-entry > .wrap > .actions .action {
  flex: initial;
}```
hohMiyazawa commented 1 year ago

This was put in at some point to make those buttons easier to click, so it's intentional.

What's your opinion on it?

krenwi commented 1 year ago

Hmm, I didn't think of this possibility at all.

If the buttons div was right-aligned, with the likes button in its original position, then it would look much less like it was an error. The extra width also seems excessive, maybe it could be reduced just a little bit.

There's making things easier then there's changing from the design paradigm so much someone might think it is a mistake. I suppose it just comes down to expectations brought on by personal experiences. I really thought it was a mistake, so every time I looked at the buttons it bothered me a bit.

Reinachan commented 1 year ago

I'd make it optional. Can't find any setting to disable it. As @krenwi said, it kinda looks like something is broken. If you want to make them easier to press, I'd make them larger rather than spreading them out more.

Reinachan commented 1 year ago

I'd also make it opt-in rather than opt-out unless it looks like it it should've been there in the first place (which it currently does not)