hohMiyazawa / Automail

An enhancement collection for anilist.co
GNU General Public License v3.0
158 stars 30 forks source link

Chapter Progress of Users with default profile pic not showing up in Social tab #267

Open FateXBlood opened 1 year ago

FateXBlood commented 1 year ago

Not sure how this came to be but it seems users with the default profile picture are somehow excluded in displaying their chapter progress.

Screenshot for relevance: image image image image

hohMiyazawa commented 1 year ago

This is because the script grabs userIDs from the image URLs, which works for all users except those with the default image.

The only reason this is done is because the Anilist API only accepts IDs for batch requests, not names, and the IDs are not visible in any other way.

One could of course look up the IDs separately, but this would slow down the process and eat into the API call limit.

All of this was known when the module was written, but it's usually not such a big problem so the proper fix (sending separate calls for the default users) was never written.

FateXBlood commented 1 year ago

I see. Thanks for responding.

hohMiyazawa commented 1 year ago

Still has to be fixed at some point