search

hohav / peppi

Rust parser for Slippi SSBM replay files
MIT License
37 stars 9 forks source link

Add support for stats #29

Open St0wy opened 1 year ago

St0wy commented 1 year ago

In the JS version of the slippi parser, there is a method to get the stats of a game getStats().

It would be nice if peppi had a way to get those.

hohav commented 1 year ago

The industrious @NickCondron is working on stats in #11. I expect it'll take time to settle on a final design, but I do want to get stats in soon!

trstruth commented 5 months ago

hey @NickCondron @hohav I see #11 is now closed, are there still plans to implement stats in this crate? Would y'all accept a PR for it?

hohav commented 5 months ago

hey @NickCondron @hohav I see #11 is now closed, are there still plans to implement stats in this crate? Would y'all accept a PR for it?

I'm still interested in stats, although I'm not convinced they belong in this crate. Do you believe they should?

I haven't heard anything about @NickCondron's work on this since https://github.com/hohav/peppi/pull/11#issuecomment-1336427910.