hohav / peppi

Rust parser for Slippi SSBM replay files
MIT License
37 stars 9 forks source link

Fix: Sum split sizes because payload size can be wrong #44

Closed NickCondron closed 1 year ago

NickCondron commented 1 year ago

Newer replays load a large enough gecko code payload that the size overflows the u16 within the payload sizes event. Therefore, we should not trust that number and instead sum the payload from each split event.

Some of the gecko codes and split event parsing code could use a refactor, but I think I will save that for a separate PR. Right now v3.13 support is blocked by this issue because in practice all v3.13 (and later) replays on dolphin have this size issue.