hohav / peppi

Rust parser for Slippi SSBM replay files
MIT License
37 stars 9 forks source link

Items not handled correctly with option Rollback::First. #52

Closed Kered13 closed 7 months ago

Kered13 commented 1 year ago

When a rollback frame comes in with an item event, that item event will be appended to the vector of items for that frame, when it should be ignored because it is a rollback frame.

Items are appended here. Notice that there is no check for the Rollback::First option, and no check if the item is part of a rollback frame or an original frame.

hohav commented 7 months ago

No longer an issue in latest main, because parsing no longer treats rollback frames specially. You'd instead use the new deduped_validity to iterate over only initial or final rollback frames.