search

hohav / peppi

Rust parser for Slippi SSBM replay files
MIT License
37 stars 9 forks source link

TrackingReader does a poor job reporting where a parse error occurred. #64

Closed NickCondron closed 7 months ago

NickCondron commented 1 year ago

When a parsed value contains invalid data, an error is returned. However the location that will get reported to the user will be the location after the end of the last read instead of before it.

hohav commented 7 months ago

I got rid of TrackingReader because of this, and instead added more logging so we can still find out where an error occurred. Beyond that, I hope to use thiserror's backtrace functionality when it's finally available on stable Rust.