search

hohav / peppi

Rust parser for Slippi SSBM replay files
MIT License
37 stars 9 forks source link

Add support for v3.16 #66

Closed NickCondron closed 5 months ago

NickCondron commented 6 months ago

https://github.com/project-slippi/slippi-wiki/blob/master/SPEC.md#post-frame-update

Latest fields added by yours truly

NickCondron commented 6 months ago

Thanks for this. Do you happen to have a v3.16 replay for tests?

Added a replay and tests. Used the v3.16 replay for the simple v3.14/v3.15 tests. More involved tests for v3.16 also added.

The v3.16 test sort of tests vanilla melee behavior, but I think it is still a useful test to verify the values make sense.

hohav commented 5 months ago

Thanks for this, @NickCondron. I ended up renaming it to last_hit_by_instance.

Did you have any trouble with the code generation?

NickCondron commented 5 months ago

Thanks for this, @NickCondron. I ended up renaming it to last_hit_by_instance.

Did you have any trouble with the code generation?

No. It went well. I just had to install a few dependencies.