hohav / py-slippi

Python library for parsing SSBM replay files
MIT License
56 stars 25 forks source link

Player name value? #14

Closed noahpodgurski closed 4 years ago

noahpodgurski commented 4 years ago

I have been looking at the API's written, and cannot seem to find any record of the player name, i.e., the netplay/smashladder name linked with the game. In case I am not explaining this well, allow me to elaborate.

When I open my smashladder application, it brings up my list of past games on the right. When I click the 'i' info button, it shows my stats and then it shows my name above the character I was playing as.

My question is, how do I access my name from the API? How does it know which character I was playing as? Has it not been added in yet? I am still very new to this so any help would be very appreciated, thanks!

hohav commented 4 years ago

As far as I know, that information is not available to Slippi and therefore isn't included in the replays it generates. The player's in-game tag is available, but that's only useful if you consistently use one.

For a better explanation, try asking the Slippi discord.

NikhilNarayana commented 4 years ago

As far as I know, that information is not available to Slippi and therefore isn't included in the replays it generates. The player's in-game tag is available, but that's only useful if you consistently use one.

For a better explanation, try asking the Slippi discord.

It is recorded in the metadata, but only for dolphin games.

hohav commented 4 years ago

Netplay names are implemented in py-slippi 1.4.1, just released. Thanks to @NikhilNarayana for the PR.