Update metadata parsing

hohav / py-slippi

Python library for parsing SSBM replay files

MIT License

56 stars 25 forks source link

Update metadata parsing #16

Closed NikhilNarayana closed 4 years ago

NikhilNarayana commented 4 years ago

Fixes #14

parse and store console nick
parse and store netplay name for each player
store the raw json for light forwards compatibility

NikhilNarayana commented 4 years ago

Game_20191203T233440.zip

A test file for where both players have a netplay name.

Game_20190324T111204.zip

A test file for console names.

hohav commented 4 years ago

Game_20191203T233440.zip

A test file for where both players have a netplay name.

Game_20190324T111204.zip

A test file for console names.

Thanks! I added tests to your branch, but can't push my commits. Is "Allow edits from maintainers" enabled on this PR?

NikhilNarayana commented 4 years ago

Game_20191203T233440.zip A test file for where both players have a netplay name. Game_20190324T111204.zip A test file for console names.

Thanks! I added tests to your branch, but can't push my commits. Is "Allow edits from maintainers" enabled on this PR?

Hmm odd, I have it enabled. Maybe just merge into a branch and make your changes there.