search

hohav / py-slippi

Python library for parsing SSBM replay files
MIT License
56 stars 25 forks source link

Brought into spec with slippi 3.0.0 #17

Closed davisdude closed 4 years ago

davisdude commented 4 years ago

Added frame start, item update, and frame bookend events

I don't have my controller or any 3.0.0 files to test with, so parts of this are untested. I did test with some 2.2.0 slippi files, so at least FrameStart seems good to me.

davisdude commented 4 years ago

Is there anything else that needs to be done for this to be merged?

hohav commented 4 years ago

Is there anything else that needs to be done for this to be merged?

Sorry for the delay; I just left some more comments. We'll also need tests, plus I want to do some performance analysis (e.g. on lists vs tuples for the item updates). There are also a few design issues I'm still mulling over, mostly around the intermediate representation of frame events.

davisdude commented 4 years ago

Sorry for the delay. I tried some basic testing, but still haven't been able to get any 3.0.0 files - only 3.3 or 3.6.

hohav commented 4 years ago

Thanks for the changes. I rebased and squashed everything from this PR into one commit in https://github.com/hohav/py-slippi/tree/items, with some additional fixes, tweaks and tests. In that branch I also implemented support for rollback frames, so it should work with replays up to the current version (though some new fields are still ignored, as I haven't added support for them yet).

Try it out and let me know if it works for you— I plan to merge my branch sometime this week.

hohav commented 4 years ago

Merged in fc5b608baeb60d1ea08c463bb2e9e4d528a0c7fe.