search

hohav / py-slippi

Python library for parsing SSBM replay files
MIT License
56 stars 25 forks source link

Added support for single updates from Dolphin #23

Closed IAmAbszol closed 3 years ago

IAmAbszol commented 3 years ago

Alfred Dolphin sends Slippi data over the network and is fed to Slippi. Unfortunately py-slippi doesn't support two things. 1: Pre and Post are always expected to be togther in a Frame, let the Frame support either or if they don't arrive or arrive late (Frame 1 ->Pre, Frame 1 ->Post). 2: Payload sizes are being attached, update the default paylkoad sizes if for some reason it has changed between meta and the network send.

hohav commented 3 years ago

Thanks for the PR! A couple questions:

  1. What is Alfred Dolphin?
  2. Could you elaborate on what you mean by "Payload sizes are being attached"? Is this documented?
IAmAbszol commented 3 years ago

Alfred Dolphin is a fork from Slippi Dolphin that provides network socket communication to/from the emulator. https://github.com/iamabszol/ishiiruka

Meh the payload sizes probably aren't needed in the main branch of py-slippi.

IAmAbszol commented 3 years ago

Pushed latest. Removed payload modification and additional while loop guard. The Pre and Post check is the only thing from the original commit to remain as single frame updates never have Pre + Post in the same message.