hohav / py-slippi

Python library for parsing SSBM replay files
MIT License
56 stars 25 forks source link

Don't use root logger #48

Open davisdude opened 1 year ago

davisdude commented 1 year ago

Python documentation recommends against logging to the root logger. This changes logging to slippi.log instead. (You could also change the logger to slippi or something else; __name__ is just the most commonplace).

It is strongly advised that you do not log to the root logger in your library. Instead, use a logger with a unique and easily identifiable name, such as the __name__ for your library’s top-level package or module. Logging to the root logger will make it difficult or impossible for the application developer to configure the logging verbosity or handlers of your library as they wish.