search

hohav / py-slippi

Python library for parsing SSBM replay files
MIT License
56 stars 25 forks source link

Handle ActionState values above 0x155 #6

Open hohav opened 5 years ago

hohav commented 5 years ago

Our enum values for ActionState at or above 0x155 (341) seem to be wrong. The spreadsheet from which this data came contains the interesting comment "nothing beyond this point is".

According to https://github.com/hohav/py-slippi/issues/4#issue-427252532 these values are character-specific states for special moves, which will require some redesign.

DustinAlandzes commented 3 years ago

it looks like slippi-js only handles 1-21, 50-56, 61, and 62: https://github.com/project-slippi/slippi-js/blob/master/src/melee/moves.ts