Adding warnings for not-processed commands and to avoid spamming the …

hohav / py-slippi

Python library for parsing SSBM replay files

MIT License

56 stars 25 forks source link

Adding warnings for not-processed commands and to avoid spamming the … #9

Closed Summate closed 5 years ago

Summate commented 5 years ago

…end user

Ignoring commands that aren't processed to allow forward compatibility

The spec specifies that parsers should ignore things they don't understand for forward compatibility and this is an issue with the latest Patreon builds. cf https://github.com/project-slippi/project-slippi/wiki/Replay-File-Spec#backwards-compatibility

hohav commented 5 years ago

Thanks for the PR. Could you upload a replay that I can use to test this?

Summate commented 5 years ago

https://github.com/madisonsmash/Slippi/raw/master/replays/Game_20190908T172144.slp

This is a game recently produced on Patreon software.

hohav commented 5 years ago

Fixed in b7597f38044d54c7cc3818f823de4f2d321c77eb. I used a different approach, but your PR was quite helpful in pointing out where the problems were. Thanks again!