Closed mabl closed 10 years ago
Thanks for the fix!
Just before you do another release: Probably you will also need to fix package_data in setup.py, right?
Also, just to make sure: What about RELEASE-VERSION?
I added the new version maintenance scripts in an attempt to automate the version numbering. Clearly, I didn't think it through well enough. Thanks for catching the problems. I think things should be working better now. What's wrong with package_data?
For future reference here's how the version updating scheme is meant to work:
1) Make revisions. Commit and tag with the updated version number.
2) Package a source distribution with setup.py sdist
. This gets the tag value from git describe --tags
, uses it as the version number, then stores it in the file gdsCAD/_version.py
3) Most users will install the package from pip or easy_install or via setup.py install
. In these cases there will be no git repo to grab the tag version from, so the version number will be taken from the file gdsCAD/_version.py
.
4) When imported the version returned by gdsCAD.__version__
will be that taken from _version.py
If you see any further problems please let me know.
OK. I see the package_data problem. I'm on it.
MANIFEST.in lists the (non python) files to copy for the distribution package. But it does not (despite documentation to the contrary) include those files when it installs the package, even when include_package_data=True
. To do that I had to revert to using the original package_data
dict in setup.py
.
All should be well now.
The current setup.py uses a module called git_version. Which does not exist, at least on the the computers I tried.