Fix GDS import function for nested Cells and large designs

hohlraum / gdsCAD

A simple but powerful Python package for creating photolithography masks in the GDSII format.

GNU General Public License v3.0

88 stars 52 forks source link

Fix GDS import function for nested Cells and large designs #33

Closed mabl closed 7 years ago

mabl commented 9 years ago

In case of nested Cell depenencies, we cannot add a Cell which may refer to cells where the dependencies are not yet solved.

So first resolve all depenencies and then add them to the library.

Furthermore, gdscad has the concept of units and precicion, which is not represented in the GDS file format. Hence care has to be taken on how to handle this.

mabl commented 9 years ago

I've tried the patch against four photonic chip designs done with commercial software of different manufacturers and it imported and reexported those files flawlessly.

muab commented 8 years ago

Thank you very much for this pull Matthias! It solves the problems I've been having to import/export. Actually thanks to it I was also able to continue execution and discover the line 1307 because my gds have cells with a name length bigger than the official limit. Your contribution should be merged with the master branch. but it seems that is no longer being maintained. Anyway thanks a lot!